FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 2.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
472 128 0 0

Files

Class Bugs
ca.uhn.hl7v2.Location$GroupLocation 1
ca.uhn.hl7v2.app.HL7Service 1
ca.uhn.hl7v2.app.HL7Service$ConnectionCleaner 1
ca.uhn.hl7v2.app.LazyConnection$LazyInitiator 1
ca.uhn.hl7v2.app.Receiver$Grunt 1
ca.uhn.hl7v2.app.Responder 4
ca.uhn.hl7v2.conf.check.DefaultValidator 1
ca.uhn.hl7v2.conf.classes.abs.FiniteList 1
ca.uhn.hl7v2.conf.parser.ProfileParser 2
ca.uhn.hl7v2.conf.spec.RuntimeProfile 3
ca.uhn.hl7v2.conf.spec.Specification 3
ca.uhn.hl7v2.conf.spec.message.AbstractComponent 1
ca.uhn.hl7v2.conf.spec.message.Field 3
ca.uhn.hl7v2.conf.spec.message.Seg 2
ca.uhn.hl7v2.conf.spec.message.SegGroup 2
ca.uhn.hl7v2.conf.store.FileProfileStore 2
ca.uhn.hl7v2.conf.store.URLProfileStore 1
ca.uhn.hl7v2.model.AbstractMessage 1
ca.uhn.hl7v2.model.Field 2
ca.uhn.hl7v2.model.v21.datatype.DT 1
ca.uhn.hl7v2.model.v21.datatype.ID 1
ca.uhn.hl7v2.model.v21.datatype.TM 1
ca.uhn.hl7v2.model.v22.datatype.DT 1
ca.uhn.hl7v2.model.v22.datatype.ID 1
ca.uhn.hl7v2.model.v22.datatype.IS 1
ca.uhn.hl7v2.model.v22.datatype.TM 1
ca.uhn.hl7v2.model.v22.datatype.TSComponentOne 1
ca.uhn.hl7v2.model.v23.datatype.DT 1
ca.uhn.hl7v2.model.v23.datatype.ID 1
ca.uhn.hl7v2.model.v23.datatype.IS 1
ca.uhn.hl7v2.model.v23.datatype.TM 1
ca.uhn.hl7v2.model.v23.datatype.TSComponentOne 1
ca.uhn.hl7v2.model.v231.datatype.DT 1
ca.uhn.hl7v2.model.v231.datatype.ID 1
ca.uhn.hl7v2.model.v231.datatype.IS 1
ca.uhn.hl7v2.model.v231.datatype.TM 1
ca.uhn.hl7v2.model.v231.datatype.TSComponentOne 1
ca.uhn.hl7v2.model.v24.datatype.DT 1
ca.uhn.hl7v2.model.v24.datatype.ID 1
ca.uhn.hl7v2.model.v24.datatype.IS 1
ca.uhn.hl7v2.model.v24.datatype.TM 1
ca.uhn.hl7v2.model.v24.datatype.TSComponentOne 1
ca.uhn.hl7v2.model.v25.datatype.DT 1
ca.uhn.hl7v2.model.v25.datatype.ID 1
ca.uhn.hl7v2.model.v25.datatype.IS 1
ca.uhn.hl7v2.model.v25.datatype.TM 1
ca.uhn.hl7v2.model.v251.datatype.DT 1
ca.uhn.hl7v2.model.v251.datatype.ID 1
ca.uhn.hl7v2.model.v251.datatype.IS 1
ca.uhn.hl7v2.model.v251.datatype.NULLDT 1
ca.uhn.hl7v2.model.v251.datatype.TM 1
ca.uhn.hl7v2.model.v26.datatype.DT 1
ca.uhn.hl7v2.model.v26.datatype.ID 1
ca.uhn.hl7v2.model.v26.datatype.IS 1
ca.uhn.hl7v2.model.v26.datatype.NULLDT 1
ca.uhn.hl7v2.model.v26.datatype.TM 1
ca.uhn.hl7v2.parser.DefaultModelClassFactory 2
ca.uhn.hl7v2.parser.DefaultXMLParser 3
ca.uhn.hl7v2.parser.EncodingCharacters 1
ca.uhn.hl7v2.parser.OldPipeParser 1
ca.uhn.hl7v2.parser.PipeParser 2
ca.uhn.hl7v2.preparser.DatumPath 4
ca.uhn.hl7v2.preparser.ER7 4
ca.uhn.hl7v2.preparser.ER7$ER7SegmentHandler 1
ca.uhn.hl7v2.preparser.XML$HL7MessageHandler 2
ca.uhn.hl7v2.protocol.impl.ApplicationLoader 2
ca.uhn.hl7v2.protocol.impl.ApplicationRouterImpl 1
ca.uhn.hl7v2.protocol.impl.JMSTopicTransport 1
ca.uhn.hl7v2.protocol.impl.JMSTransport 1
ca.uhn.hl7v2.protocol.impl.ProcessorImpl 2
ca.uhn.hl7v2.protocol.impl.ProcessorImpl$ExpiringTransportable 1
ca.uhn.hl7v2.protocol.impl.ReaderThread 1
ca.uhn.hl7v2.protocol.impl.URLTransport 3
ca.uhn.hl7v2.util.FileCodeMapper 2
ca.uhn.hl7v2.util.Hl7InputStreamMessageStringIterator 1
ca.uhn.hl7v2.util.MessageIDGenerator 4
ca.uhn.hl7v2.util.MessageNavigator$GroupContext 1
ca.uhn.hl7v2.util.Terser$PathSpec 1
ca.uhn.hl7v2.util.XMLUtils$ClasspathResourceResolver 1
ca.uhn.hl7v2.util.idgenerator.FileBasedGenerator 2
ca.uhn.hl7v2.util.idgenerator.HiLoGenerator 2
ca.uhn.hl7v2.util.idgenerator.NanoTimeGenerator 1
ca.uhn.hl7v2.validation.ReportingValidationExceptionHandler 1
ca.uhn.hl7v2.validation.builder.BuilderSupport$AllOfPredicate 1
ca.uhn.hl7v2.validation.builder.BuilderSupport$AlwaysPredicate 1
ca.uhn.hl7v2.validation.builder.BuilderSupport$AnyOfPredicate 1
ca.uhn.hl7v2.validation.builder.BuilderSupport$EmptyPredicate 1
ca.uhn.hl7v2.validation.builder.BuilderSupport$EqualsPredicate 1
ca.uhn.hl7v2.validation.builder.BuilderSupport$InPredicate 1
ca.uhn.hl7v2.validation.builder.BuilderSupport$MatchesPredicate 1
ca.uhn.hl7v2.validation.builder.BuilderSupport$NotPredicate 1
ca.uhn.hl7v2.validation.impl.ConformanceProfileRule 1
ca.uhn.hl7v2.validation.impl.XMLSchemaRule$ErrorHandler 1

ca.uhn.hl7v2.Location$GroupLocation

Bug Category Details Line Priority
Should ca.uhn.hl7v2.Location$GroupLocation be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 227 Medium

ca.uhn.hl7v2.app.HL7Service

Bug Category Details Line Priority
Found reliance on default encoding in ca.uhn.hl7v2.app.HL7Service.loadApplicationsFromFile(File): new java.io.FileReader(File) I18N DM_DEFAULT_ENCODING 311 High

ca.uhn.hl7v2.app.HL7Service$ConnectionCleaner

Bug Category Details Line Priority
Should ca.uhn.hl7v2.app.HL7Service$ConnectionCleaner be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 372 Medium

ca.uhn.hl7v2.app.LazyConnection$LazyInitiator

Bug Category Details Line Priority
Should ca.uhn.hl7v2.app.LazyConnection$LazyInitiator be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 111 Medium

ca.uhn.hl7v2.app.Receiver$Grunt

Bug Category Details Line Priority
Should ca.uhn.hl7v2.app.Receiver$Grunt be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 120 Medium

ca.uhn.hl7v2.app.Responder

Bug Category Details Line Priority
Dead store to respInbound in ca.uhn.hl7v2.app.Responder.main(String[]) STYLE DLS_DEAD_LOCAL_STORE 152 High
Dead store to respOutbound in ca.uhn.hl7v2.app.Responder.main(String[]) STYLE DLS_DEAD_LOCAL_STORE 153 High
Dead store to inMessage in ca.uhn.hl7v2.app.Responder.main(String[]) STYLE DLS_DEAD_LOCAL_STORE 144 Medium
Found reliance on default encoding in ca.uhn.hl7v2.app.Responder.main(String[]): new java.io.FileReader(File) I18N DM_DEFAULT_ENCODING 134 High

ca.uhn.hl7v2.conf.check.DefaultValidator

Bug Category Details Line Priority
Found reliance on default encoding in ca.uhn.hl7v2.conf.check.DefaultValidator.loadFile(String): new java.io.FileReader(File) I18N DM_DEFAULT_ENCODING 660 High

ca.uhn.hl7v2.conf.classes.abs.FiniteList

Bug Category Details Line Priority
ca.uhn.hl7v2.conf.classes.abs.FiniteList.createRep(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 83 Medium

ca.uhn.hl7v2.conf.parser.ProfileParser

Bug Category Details Line Priority
Found reliance on default encoding in ca.uhn.hl7v2.conf.parser.ProfileParser.main(String[]): new java.io.FileReader(File) I18N DM_DEFAULT_ENCODING 477 High
Found reliance on default encoding in ca.uhn.hl7v2.conf.parser.ProfileParser.parseClasspath(String): new String(byte[], int, int) I18N DM_DEFAULT_ENCODING 145 High

ca.uhn.hl7v2.conf.spec.RuntimeProfile

Bug Category Details Line Priority
Read of unwritten field encodings in ca.uhn.hl7v2.conf.spec.RuntimeProfile.getEncodings(int) CORRECTNESS NP_UNWRITTEN_FIELD 88 Medium
Read of unwritten field encodings in ca.uhn.hl7v2.conf.spec.RuntimeProfile.setEncodings(int, Encoding) CORRECTNESS NP_UNWRITTEN_FIELD 214 Medium
Unwritten field: ca.uhn.hl7v2.conf.spec.RuntimeProfile.encodings CORRECTNESS UWF_UNWRITTEN_FIELD 88 Medium

ca.uhn.hl7v2.conf.spec.Specification

Bug Category Details Line Priority
Read of unwritten field encodings in ca.uhn.hl7v2.conf.spec.Specification.getEncodings(int) CORRECTNESS NP_UNWRITTEN_FIELD 144 Medium
Read of unwritten field encodings in ca.uhn.hl7v2.conf.spec.Specification.setEncodings(int, Encoding) CORRECTNESS NP_UNWRITTEN_FIELD 154 Medium
Unwritten field: ca.uhn.hl7v2.conf.spec.Specification.encodings CORRECTNESS UWF_UNWRITTEN_FIELD 144 Medium

ca.uhn.hl7v2.conf.spec.message.AbstractComponent

Bug Category Details Line Priority
ca.uhn.hl7v2.conf.spec.message.AbstractComponent.setLength(long) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 274 Medium

ca.uhn.hl7v2.conf.spec.message.Field

Bug Category Details Line Priority
ca.uhn.hl7v2.conf.spec.message.Field.setItemNo(short) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 119 Medium
ca.uhn.hl7v2.conf.spec.message.Field.setMax(short) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 96 Medium
ca.uhn.hl7v2.conf.spec.message.Field.setMin(short) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 73 Medium

ca.uhn.hl7v2.conf.spec.message.Seg

Bug Category Details Line Priority
ca.uhn.hl7v2.conf.spec.message.Seg.setMax(short) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 294 Medium
ca.uhn.hl7v2.conf.spec.message.Seg.setMin(short) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 271 Medium

ca.uhn.hl7v2.conf.spec.message.SegGroup

Bug Category Details Line Priority
ca.uhn.hl7v2.conf.spec.message.SegGroup.setMax(short) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 194 Medium
ca.uhn.hl7v2.conf.spec.message.SegGroup.setMin(short) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 171 Medium

ca.uhn.hl7v2.conf.store.FileProfileStore

Bug Category Details Line Priority
Found reliance on default encoding in ca.uhn.hl7v2.conf.store.FileProfileStore.getProfile(String): new java.io.FileReader(File) I18N DM_DEFAULT_ENCODING 48 High
Found reliance on default encoding in ca.uhn.hl7v2.conf.store.FileProfileStore.persistProfile(String, String): new java.io.FileWriter(File) I18N DM_DEFAULT_ENCODING 73 High

ca.uhn.hl7v2.conf.store.URLProfileStore

Bug Category Details Line Priority
Found reliance on default encoding in ca.uhn.hl7v2.conf.store.URLProfileStore.getProfile(String): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 49 High

ca.uhn.hl7v2.model.AbstractMessage

Bug Category Details Line Priority
Redundant nullcheck of ca.uhn.hl7v2.model.AbstractMessage.getParser(), which is known to be non-null in ca.uhn.hl7v2.model.AbstractMessage.instantiateACK() STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 242 Medium

ca.uhn.hl7v2.model.Field

Bug Category Details Line Priority
new ca.uhn.hl7v2.model.Field(Type[], int) may expose internal representation by storing an externally mutable object into Field.reps MALICIOUS_CODE EI_EXPOSE_REP2 44 Medium
Unread field: ca.uhn.hl7v2.model.Field.maxCardinality PERFORMANCE URF_UNREAD_FIELD 45 Medium

ca.uhn.hl7v2.model.v21.datatype.DT

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v21.datatype.DT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.DT BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 53 High

ca.uhn.hl7v2.model.v21.datatype.ID

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v21.datatype.ID shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.ID BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 59 High

ca.uhn.hl7v2.model.v21.datatype.TM

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v21.datatype.TM shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TM BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 72 High

ca.uhn.hl7v2.model.v22.datatype.DT

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v22.datatype.DT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.DT BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 53 High

ca.uhn.hl7v2.model.v22.datatype.ID

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v22.datatype.ID shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.ID BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 59 High

ca.uhn.hl7v2.model.v22.datatype.IS

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v22.datatype.IS shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.IS BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 53 High

ca.uhn.hl7v2.model.v22.datatype.TM

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v22.datatype.TM shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TM BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 72 High

ca.uhn.hl7v2.model.v22.datatype.TSComponentOne

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v22.datatype.TSComponentOne shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TSComponentOne BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 89 High

ca.uhn.hl7v2.model.v23.datatype.DT

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v23.datatype.DT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.DT BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 53 High

ca.uhn.hl7v2.model.v23.datatype.ID

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v23.datatype.ID shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.ID BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 59 High

ca.uhn.hl7v2.model.v23.datatype.IS

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v23.datatype.IS shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.IS BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 53 High

ca.uhn.hl7v2.model.v23.datatype.TM

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v23.datatype.TM shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TM BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 72 High

ca.uhn.hl7v2.model.v23.datatype.TSComponentOne

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v23.datatype.TSComponentOne shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TSComponentOne BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 89 High

ca.uhn.hl7v2.model.v231.datatype.DT

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v231.datatype.DT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.DT BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 53 High

ca.uhn.hl7v2.model.v231.datatype.ID

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v231.datatype.ID shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.ID BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 59 High

ca.uhn.hl7v2.model.v231.datatype.IS

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v231.datatype.IS shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.IS BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 53 High

ca.uhn.hl7v2.model.v231.datatype.TM

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v231.datatype.TM shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TM BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 72 High

ca.uhn.hl7v2.model.v231.datatype.TSComponentOne

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v231.datatype.TSComponentOne shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TSComponentOne BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 89 High

ca.uhn.hl7v2.model.v24.datatype.DT

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v24.datatype.DT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.DT BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 53 High

ca.uhn.hl7v2.model.v24.datatype.ID

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v24.datatype.ID shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.ID BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 58 High

ca.uhn.hl7v2.model.v24.datatype.IS

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v24.datatype.IS shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.IS BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 53 High

ca.uhn.hl7v2.model.v24.datatype.TM

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v24.datatype.TM shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TM BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 72 High

ca.uhn.hl7v2.model.v24.datatype.TSComponentOne

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v24.datatype.TSComponentOne shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TSComponentOne BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 86 High

ca.uhn.hl7v2.model.v25.datatype.DT

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v25.datatype.DT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.DT BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 53 High

ca.uhn.hl7v2.model.v25.datatype.ID

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v25.datatype.ID shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.ID BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 58 High

ca.uhn.hl7v2.model.v25.datatype.IS

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v25.datatype.IS shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.IS BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 53 High

ca.uhn.hl7v2.model.v25.datatype.TM

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v25.datatype.TM shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TM BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 72 High

ca.uhn.hl7v2.model.v251.datatype.DT

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v251.datatype.DT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.DT BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 53 High

ca.uhn.hl7v2.model.v251.datatype.ID

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v251.datatype.ID shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.ID BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 58 High

ca.uhn.hl7v2.model.v251.datatype.IS

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v251.datatype.IS shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.IS BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 53 High

ca.uhn.hl7v2.model.v251.datatype.NULLDT

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v251.datatype.NULLDT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.NULLDT BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 26 High

ca.uhn.hl7v2.model.v251.datatype.TM

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v251.datatype.TM shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TM BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 72 High

ca.uhn.hl7v2.model.v26.datatype.DT

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v26.datatype.DT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.DT BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 53 High

ca.uhn.hl7v2.model.v26.datatype.ID

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v26.datatype.ID shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.ID BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 58 High

ca.uhn.hl7v2.model.v26.datatype.IS

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v26.datatype.IS shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.IS BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 53 High

ca.uhn.hl7v2.model.v26.datatype.NULLDT

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v26.datatype.NULLDT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.NULLDT BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 26 High

ca.uhn.hl7v2.model.v26.datatype.TM

Bug Category Details Line Priority
The class name ca.uhn.hl7v2.model.v26.datatype.TM shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TM BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 72 High

ca.uhn.hl7v2.parser.DefaultModelClassFactory

Bug Category Details Line Priority
Found reliance on default encoding in ca.uhn.hl7v2.parser.DefaultModelClassFactory.loadPackages(String): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 268 High
ca.uhn.hl7v2.parser.DefaultModelClassFactory.loadPackages(String) may fail to close stream BAD_PRACTICE OS_OPEN_STREAM 268 Medium

ca.uhn.hl7v2.parser.DefaultXMLParser

Bug Category Details Line Priority
Found reliance on default encoding in ca.uhn.hl7v2.parser.DefaultXMLParser.main(String[]): new java.io.FileReader(File) I18N DM_DEFAULT_ENCODING 346 High
Possible null pointer dereference of inParser in ca.uhn.hl7v2.parser.DefaultXMLParser.main(String[]) CORRECTNESS NP_NULL_ON_SOME_PATH 366 Medium
Possible null pointer dereference of outParser in ca.uhn.hl7v2.parser.DefaultXMLParser.main(String[]) CORRECTNESS NP_NULL_ON_SOME_PATH 369 Medium

ca.uhn.hl7v2.parser.EncodingCharacters

Bug Category Details Line Priority
ca.uhn.hl7v2.parser.EncodingCharacters.clone() does not call super.clone() BAD_PRACTICE CN_IDIOM_NO_SUPER_CALL 174 Medium

ca.uhn.hl7v2.parser.OldPipeParser

Bug Category Details Line Priority
Redundant nullcheck of fieldSepString, which is known to be non-null in ca.uhn.hl7v2.parser.OldPipeParser.doEncode(Message) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 445 Medium

ca.uhn.hl7v2.parser.PipeParser

Bug Category Details Line Priority
ca.uhn.hl7v2.parser.PipeParser.encode(Segment, EncodingCharacters, ParserConfiguration, String) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 833 Medium
ca.uhn.hl7v2.parser.PipeParser.encode(Type, EncodingCharacters, ParserConfiguration, String) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 558 Medium

ca.uhn.hl7v2.preparser.DatumPath

Bug Category Details Line Priority
ca.uhn.hl7v2.preparser.DatumPath.clone() does not call super.clone() BAD_PRACTICE CN_IDIOM_NO_SUPER_CALL 266 Medium
ca.uhn.hl7v2.preparser.DatumPath.add(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 209 Medium
ca.uhn.hl7v2.preparser.DatumPath.main(String[]) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 307 Medium
ca.uhn.hl7v2.preparser.DatumPath defines equals and uses Object.hashCode() BAD_PRACTICE HE_EQUALS_USE_HASHCODE 53 High

ca.uhn.hl7v2.preparser.ER7

Bug Category Details Line Priority
ca.uhn.hl7v2.preparser.ER7.parseMSHSegmentWhole(Properties, List, EncodingCharacters, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 99 Medium
ca.uhn.hl7v2.preparser.ER7.parseSegmentGuts(ER7$Handler, String, List) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 252 Medium
ca.uhn.hl7v2.preparser.ER7.parseSegmentWhole(Properties, Map, List, EncodingCharacters, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 139 Medium
ca.uhn.hl7v2.preparser.ER7.parseMessage(Properties, List, String) invokes inefficient new String(String) constructor PERFORMANCE DM_STRING_CTOR 63 Medium

ca.uhn.hl7v2.preparser.ER7$ER7SegmentHandler

Bug Category Details Line Priority
ca.uhn.hl7v2.preparser.ER7$ER7SegmentHandler.putDatum(List, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 210 Medium

ca.uhn.hl7v2.preparser.XML$HL7MessageHandler

Bug Category Details Line Priority
ca.uhn.hl7v2.preparser.XML$HL7MessageHandler.tryToGrowDocLocationFromElementName(StringBuffer, DatumPath, Map, DatumPath, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 284 Medium
ca.uhn.hl7v2.preparser.XML$HL7MessageHandler.clear() invokes inefficient new String() constructor PERFORMANCE DM_STRING_VOID_CTOR 139 Medium

ca.uhn.hl7v2.protocol.impl.ApplicationLoader

Bug Category Details Line Priority
Found reliance on default encoding in ca.uhn.hl7v2.protocol.impl.ApplicationLoader.loadApplications(ApplicationRouter, URL): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 80 High
ca.uhn.hl7v2.protocol.impl.ApplicationLoader.loadApplications(ApplicationRouter, URL) may fail to close stream BAD_PRACTICE OS_OPEN_STREAM 80 Medium

ca.uhn.hl7v2.protocol.impl.ApplicationRouterImpl

Bug Category Details Line Priority
ca.uhn.hl7v2.protocol.impl.ApplicationRouterImpl.RAW_MESSAGE_KEY isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 48 High

ca.uhn.hl7v2.protocol.impl.JMSTopicTransport

Bug Category Details Line Priority
Unread field: ca.uhn.hl7v2.protocol.impl.JMSTopicTransport.myMessageSelector PERFORMANCE URF_UNREAD_FIELD 77 Medium

ca.uhn.hl7v2.protocol.impl.JMSTransport

Bug Category Details Line Priority
instanceof will always return true for all nonnull values in ca.uhn.hl7v2.protocol.impl.JMSTransport.toMessage(Transportable), since all javax.jms.TextMessage are instances of javax.jms.TextMessage STYLE BC_VACUOUS_INSTANCEOF 149 Medium

ca.uhn.hl7v2.protocol.impl.ProcessorImpl

Bug Category Details Line Priority
ca.uhn.hl7v2.protocol.impl.ProcessorImpl.reserve(String, long) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 227 Medium
new ca.uhn.hl7v2.protocol.impl.ProcessorImpl(ProcessorContext, boolean) invokes Thread.start() MT_CORRECTNESS SC_START_IN_CTOR 96 Medium

ca.uhn.hl7v2.protocol.impl.ProcessorImpl$ExpiringTransportable

Bug Category Details Line Priority
Should ca.uhn.hl7v2.protocol.impl.ProcessorImpl$ExpiringTransportable be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 486 Medium

ca.uhn.hl7v2.protocol.impl.ReaderThread

Bug Category Details Line Priority
new ca.uhn.hl7v2.protocol.impl.ReaderThread(Reader, char[], IntRef) may expose internal representation by storing an externally mutable object into ReaderThread.myBuffer MALICIOUS_CODE EI_EXPOSE_REP2 57 Medium

ca.uhn.hl7v2.protocol.impl.URLTransport

Bug Category Details Line Priority
Found reliance on default encoding in ca.uhn.hl7v2.protocol.impl.URLTransport.doReceive(): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 126 High
Found reliance on default encoding in ca.uhn.hl7v2.protocol.impl.URLTransport.doSend(Transportable): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 105 High
ca.uhn.hl7v2.protocol.impl.URLTransport.doSend(Transportable) may fail to close stream BAD_PRACTICE OS_OPEN_STREAM 105 Medium

ca.uhn.hl7v2.util.FileCodeMapper

Bug Category Details Line Priority
Found reliance on default encoding in ca.uhn.hl7v2.util.FileCodeMapper.refreshCache(): new java.io.FileReader(File) I18N DM_DEFAULT_ENCODING 116 High
Dereference of the result of readLine() without nullcheck in ca.uhn.hl7v2.util.FileCodeMapper.refreshCache() STYLE NP_DEREFERENCE_OF_READLINE_VALUE 119 Medium

ca.uhn.hl7v2.util.Hl7InputStreamMessageStringIterator

Bug Category Details Line Priority
Found reliance on default encoding in new ca.uhn.hl7v2.util.Hl7InputStreamMessageStringIterator(InputStream): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 54 High

ca.uhn.hl7v2.util.MessageIDGenerator

Bug Category Details Line Priority
Found reliance on default encoding in ca.uhn.hl7v2.util.MessageIDGenerator.getNewID(): new java.io.FileWriter(String, boolean) I18N DM_DEFAULT_ENCODING 151 High
Found reliance on default encoding in ca.uhn.hl7v2.util.MessageIDGenerator.initialize(): new java.io.FileReader(String) I18N DM_DEFAULT_ENCODING 94 High
Call to Boolean.equals(String) in ca.uhn.hl7v2.util.MessageIDGenerator.getNewID() CORRECTNESS EC_UNRELATED_TYPES 156 High
Call to Boolean.equals(String) in ca.uhn.hl7v2.util.MessageIDGenerator.initialize() CORRECTNESS EC_UNRELATED_TYPES 121 High

ca.uhn.hl7v2.util.MessageNavigator$GroupContext

Bug Category Details Line Priority
Should ca.uhn.hl7v2.util.MessageNavigator$GroupContext be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 287 Medium

ca.uhn.hl7v2.util.Terser$PathSpec

Bug Category Details Line Priority
Should ca.uhn.hl7v2.util.Terser$PathSpec be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 496 Medium

ca.uhn.hl7v2.util.XMLUtils$ClasspathResourceResolver

Bug Category Details Line Priority
ca.uhn.hl7v2.util.XMLUtils$ClasspathResourceResolver.resolveResource(String, String, String, String, String) may fail to clean up java.io.InputStream EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION 146 Medium

ca.uhn.hl7v2.util.idgenerator.FileBasedGenerator

Bug Category Details Line Priority
Found reliance on default encoding in ca.uhn.hl7v2.util.idgenerator.FileBasedGenerator.readInitialValue(String): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 116 High
Found reliance on default encoding in ca.uhn.hl7v2.util.idgenerator.FileBasedGenerator.writeNextValue(long): new java.io.PrintWriter(OutputStream) I18N DM_DEFAULT_ENCODING 97 High

ca.uhn.hl7v2.util.idgenerator.HiLoGenerator

Bug Category Details Line Priority
Inconsistent synchronization of ca.uhn.hl7v2.util.idgenerator.HiLoGenerator.base; locked 80% of time MT_CORRECTNESS IS2_INCONSISTENT_SYNC 92 Medium
Inconsistent synchronization of ca.uhn.hl7v2.util.idgenerator.HiLoGenerator.lo; locked 80% of time MT_CORRECTNESS IS2_INCONSISTENT_SYNC 91 Medium

ca.uhn.hl7v2.util.idgenerator.NanoTimeGenerator

Bug Category Details Line Priority
ca.uhn.hl7v2.util.idgenerator.NanoTimeGenerator.getID() calls Thread.sleep() with a lock held MT_CORRECTNESS SWL_SLEEP_WITH_LOCK_HELD 41 Medium

ca.uhn.hl7v2.validation.ReportingValidationExceptionHandler

Bug Category Details Line Priority
Switch statement found in ca.uhn.hl7v2.validation.ReportingValidationExceptionHandler.onExceptions(ValidationException[]) where one case falls through to the next case STYLE SF_SWITCH_FALLTHROUGH 68 Medium

ca.uhn.hl7v2.validation.builder.BuilderSupport$AllOfPredicate

Bug Category Details Line Priority
Should ca.uhn.hl7v2.validation.builder.BuilderSupport$AllOfPredicate be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 505 Medium

ca.uhn.hl7v2.validation.builder.BuilderSupport$AlwaysPredicate

Bug Category Details Line Priority
Should ca.uhn.hl7v2.validation.builder.BuilderSupport$AlwaysPredicate be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 311 Medium

ca.uhn.hl7v2.validation.builder.BuilderSupport$AnyOfPredicate

Bug Category Details Line Priority
Should ca.uhn.hl7v2.validation.builder.BuilderSupport$AnyOfPredicate be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 476 Medium

ca.uhn.hl7v2.validation.builder.BuilderSupport$EmptyPredicate

Bug Category Details Line Priority
Should ca.uhn.hl7v2.validation.builder.BuilderSupport$EmptyPredicate be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 426 Medium

ca.uhn.hl7v2.validation.builder.BuilderSupport$EqualsPredicate

Bug Category Details Line Priority
Should ca.uhn.hl7v2.validation.builder.BuilderSupport$EqualsPredicate be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 402 Medium

ca.uhn.hl7v2.validation.builder.BuilderSupport$InPredicate

Bug Category Details Line Priority
Should ca.uhn.hl7v2.validation.builder.BuilderSupport$InPredicate be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 347 Medium

ca.uhn.hl7v2.validation.builder.BuilderSupport$MatchesPredicate

Bug Category Details Line Priority
Should ca.uhn.hl7v2.validation.builder.BuilderSupport$MatchesPredicate be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 445 Medium

ca.uhn.hl7v2.validation.builder.BuilderSupport$NotPredicate

Bug Category Details Line Priority
Should ca.uhn.hl7v2.validation.builder.BuilderSupport$NotPredicate be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 378 Medium

ca.uhn.hl7v2.validation.impl.ConformanceProfileRule

Bug Category Details Line Priority
Inconsistent synchronization of ca.uhn.hl7v2.validation.impl.ConformanceProfileRule.enableCaching; locked 50% of time MT_CORRECTNESS IS2_INCONSISTENT_SYNC 194 Medium

ca.uhn.hl7v2.validation.impl.XMLSchemaRule$ErrorHandler

Bug Category Details Line Priority
Should ca.uhn.hl7v2.validation.impl.XMLSchemaRule$ErrorHandler be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 83 Medium